This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: [RFC] Proposal for m*vc build issue (#138)
- From: Grégory Pakosz <gpakosz at myscript dot com>
- To: "libffi-discuss at sourceware dot org" <libffi-discuss at sourceware dot org>
- Date: Wed, 12 Nov 2014 13:45:57 +0000
- Subject: Re: [RFC] Proposal for m*vc build issue (#138)
- Authentication-results: sourceware.org; auth=none
- References: <20141112130755 dot GA24721 at linux dot vnet dot ibm dot com> <54635DAB dot 3080800 at redhat dot com> <20141112132624 dot GA27444 at linux dot vnet dot ibm dot com>,<20141112133551 dot GA28796 at linux dot vnet dot ibm dot com>
About GCC and --std==c99
I noticed dlmalloc.c that ships with libffi contains #if defined (__GNUC__) && defined(i386)
This really should be #if defined (__GNUC__) && defined(__i386__) because when compiling with -std=c99, i386 is not defined whereas __i386__ is.
Gregory
________________________________________
From: libffi-discuss-owner@sourceware.org <libffi-discuss-owner@sourceware.org> on behalf of Dominik Vogt <vogt@linux.vnet.ibm.com>
Sent: Wednesday, November 12, 2014 2:35 PM
To: libffi-discuss@sourceware.org
Subject: Re: [RFC] Proposal for m*vc build issue (#138)
On Wed, Nov 12, 2014 at 02:26:24PM +0100, Dominik Vogt wrote:
> On Wed, Nov 12, 2014 at 02:16:27PM +0100, Richard Henderson wrote:
> > > It might be good to
> > > specifically double check the detection of a compiler with complex
> > > support using macros.
> >
> > Looks good to me.
>
> ... but doesn't work with the gcc I use. I'll check what's going
> on. Maybe the no-complex case should generate a warning.
Hm, my gcc does not define __STDC_VERSION__ unless called
specifically with --std=c99 (or maybe other settings too that I did
not check). So the test always thinks that complex types are not
available.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany