This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: Fix powerpc breakage from 6e8a4460
- From: Alan Modra <amodra at gmail dot com>
- To: Dominik Vogt <vogt at linux dot vnet dot ibm dot com>
- Cc: libffi-discuss at sourceware dot org
- Date: Tue, 11 Nov 2014 23:49:45 +1030
- Subject: Re: Fix powerpc breakage from 6e8a4460
- Authentication-results: sourceware.org; auth=none
- References: <20141110042442 dot GH3990 at bubble dot grove dot modra dot org> <20141110095107 dot GA3657 at linux dot vnet dot ibm dot com>
On Mon, Nov 10, 2014 at 10:51:07AM +0100, Dominik Vogt wrote:
> On Mon, Nov 10, 2014 at 02:54:42PM +1030, Alan Modra wrote:
> > The addition of FFI_TYPE_COMPLEX broke powerpc libffi, showing up as
> > four testsuite failures on powerpc64le. This fixes the breakage and
> > ensures a more spectacular set of failures if something like this
> > happens again.
> >
> > * src/powerpc/ffitarget.h: #error on unexpected FFI_TYPE_LAST.
> ...
> > +/* ppc_closure.S and linux64_closure.S expect this. */
> > +#define FFI_PPC_TYPE_LAST FFI_TYPE_POINTER
> > +
> > +/* We define additional types below. If generic types are added that
> > + must be supported by powerpc libffi then it is likely that
> > + FFI_PPC_TYPE_LAST needs increasing *and* the jump tables in
> > + ppc_closure.S and linux64_closure.S be extended. */
>
> Does this affect only powerpc? Is there any risk of breaking other
> platforms too?
My patch only fixes powerpc. I hadn't looked at other targets,
but a quick grep shows at least alpha-osf, ia64, and some x86 targets
were broken by changing FFI_TYPE_LAST.
--
Alan Modra
Australia Development Lab, IBM