This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: [PATCH] Fix make closures.c use dlmmap,dlmunmap on cygwin.
- From: Andrew Haley <aph at redhat dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Rainer Emrich <rainer at emrich-ebersheim dot de>, Java Patches <java-patches at gcc dot gnu dot org>, libffi-discuss at sourceware dot org
- Date: Wed, 08 Jul 2009 10:06:51 +0100
- Subject: Re: [PATCH] Fix make closures.c use dlmmap,dlmunmap on cygwin.
- References: <4A535603.3010508@gmail.com>
Dave Korn wrote:
> [ Re: http://gcc.gnu.org/ml/gcc-patches/2009-06/threads.html#02228 ]
>
> Hey all,
>
> Take 2 of this patch. Works in the simplest way possible, by saying that
> cygwin is an exception to the rule about win32/64 platforms not using the
> local dlmmap/dlmunmap implementations.
>
> Sticklers for formatting will note that two of the #endif lines reach 81
> characters, because of the comment repeating the #if condition. I didn't
> think it was worth wrapping the lines for such a tiny excess length in
> something this trivial, but I'll do so before committing if that's what the
> maintainers decide.
>
> libffi/ChangeLog:
>
> * closures.c (mmap, munmap): Don't define replacement macros pointing
> to dl* versions on windows platforms.
>
> Bootstrapping now. Assuming it completes and libffi tests run alright, OK?
Sure: obvious/trivial, fixes bootstrap.
Commit upstream and gcc trees, please.
Andrew.