Re: [PATCH] PAGE_SIZE definition for MIPS XLP

["Joseph S. Myers" <joseph at codesourcery dot com>]

On Mon, 18 Nov 2013, Andrew Pinski wrote:

> I think my attached patch is better way of fixing this issue which
> just deletes them rather than special casing them.

Deleting (for both MIPS and MicroBlaze) would indeed be better if the API 
for these symbols is that they should only be defined if the kernel page 
size is constant.

Someone still needs to look into the API for all these symbols and write a 
proper explanation of how they are used (outside of glibc) and what 
requirements apply to them.  It's not clear whether it's right to remove 
the whole block from PAGE_SHIFT to HOST_STACK_END_ADDR, or only a subset 
that directly depend on the page size; that may depend on whether the 
other symbols are ever used in a context not also depending on PAGE_SIZE 
(are they only for BFD's trad-core?).  Given such an explanation, we can 
better judge a removal patch.  I don't want "this causes problems, so 
remove it"; I want "this is incorrect because (explanation of the 
interface), so removing it is correct".

Note that IA64 confuses things by defining a subset of the macros, 
including defining NBPG to PAGE_SIZE despite that header not defining 
PAGE_SIZE.

The patch does of course need a proper bug number from glibc Bugzilla (as 
I noted, either a bug needs filing for all affected architectures, or 
separate bugs for each architecture, in accordance with glibc practice 
that if fixing a bug that was user-visible in a release then you also file 
it in Bugzilla to make searches of fixed bugs more useful) and the path in 
the ChangeLog entry given without the initial ports/, as appropriate for 
ChangeLog.mips.

-- 
Joseph S. Myers
joseph@codesourcery.com