This is the mail archive of the mailing list for the libc-ports project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Speed up libm on MIPS

On Fri, 20 Sep 2013, Carlos O'Donell wrote:

> > 2013-09-19  Steve Ellcey  <>
> > 
> > 	* sysdeps/mips/fpu_control.h (_FPU_RC_MASK): New.
> > 	* sysdeps/mips/fpu/fegetround.c (fegetround): Use _FPU_RC_MASK.
> > 	* sysdeps/mips/fpu/fesetround.c (fesetround): Use _FPU_RC_MASK.
> Looks good to me. You should just check this in as an obvious cleanup.

 Except with a small formatting fix to comply with the GNU Coding 

On Fri, 20 Sep 2013, Steve Ellcey wrote:

> diff --git a/ports/sysdeps/mips/fpu_control.h b/ports/sysdeps/mips/fpu_control.h
> index 4046962..f26b736 100644
> --- a/ports/sysdeps/mips/fpu_control.h
> +++ b/ports/sysdeps/mips/fpu_control.h
> @@ -90,6 +90,8 @@ extern fpu_control_t __fpu_control;
>  #define _FPU_RC_ZERO    0x1
>  #define _FPU_RC_UP      0x2
>  #define _FPU_RC_DOWN    0x3
> +/* mask for rounding control */
> +#define _FPU_RC_MASK    0x3

-- the comment is expected to say:

/* Mask for rounding control.  */

i.e. start with a capital letter, end with a full stop and put two spaces 
exactly after the full stop.

 According to the GNU Coding Standards all comments have to be proper 
sentences with two spaces following every punctuation mark ending a 
sentence.  For further details please refer to:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]