This is the mail archive of the mailing list for the libc-ports project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] ARM: Improve armv7 memcpy performance.

On Mon, 9 Sep 2013, Will Newton wrote:

> I believe the glibc memcpy benchmark is not capable in its present
> form of showing the difference between this version of the code and
> the current one:
> 1. The variety of alignments benchmarked is not adequate
> 2. The variability of the benchmark results is quite high (more runs
> required and page allocation issue)
> 3. The output of the benchmark contains no measure of variance
> 4. There is no means of showing graphically the output of the
> benchmark (for subtle differences this is necessary IMO)

Please make sure the wiki todo list 
<> includes all 
these areas for improvement of the benchmarks.

> These are all surmountable problems but I would rather not gate
> acceptance of this code on a satisfactory resolution of the above
> issues. I can provide output from the cortex-strings benchmark quite
> instead though.

If your summary of the benchmarking discussion indicates that the existing 
glibc benchmark is not relevant for the cases addressed by the patch, then 
it's indeed appropriate to give such results from another benchmark.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]