This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [RFC] hppa: add fanotify_mark


On Wed, 21 Aug 2013, Mike Frysinger wrote:

> Another example of all the 64bit arches getting the definition via a
> common file, but the 32bit ones all adding it by themselves and hppa
> was missed.

How about adding an architecture-independent testcase (Linux-specific, of 
course) for this function?  I've no idea whether it can test any semantics 
of fanotify_init / fanotify_mark, or only that calls to them link OK, but 
in general when fixing bugs it's a good idea to add testcases that would 
have detected them, and both functions are in my list of untested symbols 
<http://sourceware.org/ml/libc-alpha/2013-07/msg00386.html>, which we need 
to add test coverage for bit by bit.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]