This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, v5] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC.


On 30 April 2013 18:07, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Tue, 30 Apr 2013, Will Newton wrote:
>
>>       * sysdeps/arm/configure.in: Require binutils 2.21 to build
>>       for armv7.
>
>         * sysdeps/arm/configure: Regenerated.

I added that to the changelog, but the actual change to configure is
still omitted from the patch.

>> +# If we are configuring for armv7 we need binutils 2.21 to ensure that
>> +# NEON alignments are assembled correctly.
>> +if test $machine = arm/armv7; then
>> +   AC_CHECK_PROG_VER(AS, $AS, --version,
>> +               [GNU assembler.* \([0-9]*\.[0-9.]*\)],
>> +               [2.1[0-9][0-9]*|2.[2-9][1-9]*|[3-9].*|[1-9][0-9]*], AS=: critic_missing="$critic_missing as")
>
> That looks like it would reject versions 2.30, 2.40, ... - and does this
> run early enough for the critic_missing setting to be effective?

No, you're right. I've fixed up the error handling and the glob.

--
Will Newton
Toolchain Working Group, Linaro


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]