This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE (take 2)


On Tue, Sep 18, 2012 at 02:57:17PM -0400, Carlos O'Donell wrote:
> On 9/18/2012 1:06 PM, Roland McGrath wrote:
> > That looks fine to me, though I am having second thoughts about the exact
> > choice of name.  SYMBOL_SIZE doesn't really communicate that it computes
> > based on ., i.e. that the placement of the macro relative to assembly code
> > following the symbol is crucial.  Good names are not coming to mind just now.
> 
> Imply that it's computed: SYMBOL_CALC_SIZE?
> 
> Imply that it's positional: SYMBOL_HERE_SIZE?

Or what about 'COMPUTE_SYMBOL_SIZE' or 'SYMBOL_SIZE_EXPR' or just
'SIZE_EXPR'?  I tried to find something similar in binutils and kernel, but they
aren't using any kind of macro for this.

	Marek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]