This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Unify pthread_spin_[try]lock implementations.


> This is just an indentation artifact in git commit log.  It will be
> properly formatted in the actual ChangeLog file.

OK.  Note that we don't use long things like ChangeLog fragments for the
git commit messages, just a short subject line.

> The machine-specific pthread_spin_lock.c files go to
> ports/sysdeps/<machine>/nptl/pthread_spin_lock.c, which comes first in
> sysdeps search path before the generic nptl/pthread_spin_lock.c.  So it
> is either '#include_next <nptl/pthread_spin_lock.c>' or '#include
> "../../../../nptl/pthread_spin_lock.c"'.  The former looks less ugly than
> the later.

Hmm.  Last I knew #include_next from a main source file didn't work as you
expect.  Did GCC change?


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]