This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] linux-generic: avoid "redefined" warnings for open_not_cancel{,_2}

On 5/15/2012 4:46 PM, Roland McGrath wrote:
>> Fair enough, but my concern was: what guard?  Should I be very explicit and use
>>
>> #ifndef _SYSDEPS_UNIX_SYSV_LINUX_GENERIC_NOT_CANCEL_H
>> # define _SYSDEPS_UNIX_SYSV_LINUX_GENERIC_NOT_CANCEL_H
>> ...
>> #endif
> That is OK but we've usually been not quite so verbose and just use a name
> that is sufficiently unique, e.g. _LINUX_GENERIC_NOT_CANCEL_H.

OK, I'll commit the obvious change using that name.  Thanks.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]