This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ia64: move from main tree


On Mon, Apr 16, 2012 at 2:04 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Monday 16 April 2012 12:53:53 Roland McGrath wrote:
>> I'm not going to review any of the ia64 content. ?I'll just say that I
>> think this should be done with multiple commits, each with proper ChangeLog
>> bits. ?First, just resurrect old files verbatim. ?Then each of your bullet
>> items is a separate commit with normal detailed entries in ChangeLog.ia64.
>
> i couldn't tell if people would be ok merging code that is known to be broken.
> i could break up this commit into multiple ones (original code + mangling
> afterwards), but really none of it would be usable until all of it was merged.

You want others to help you! :-)

What matters is that you make it easy for others to review your ia64 fix.

If you submit restoration + fix then I can't easily spot check the
changes and recommend fixes.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]