This is the mail archive of the mailing list for the libc-ports project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

MIPS sys/epoll.h

I've applied this patch to update the MIPS sys/epoll.h in line with a 
recent libc change.

The Alpha and PA versions could do with similar updates.  (In general the 
Alpha and PA sysdeps files haven't been updated very reliably for libc 
changes in the past few years, and could do with a general review against 
all changes to the corresponding libc files since those architectures 
moved to ports, to bring them properly up to date again.)

Recall that sys/epoll.h - and similarly eventfd.h, inotify.h, signalfd.h, 
timerfd.h - is a header where the normal approach would be to have a 
single version for all Linux targets and a bits/ header with only the 
architecture-specific EPOLL_CLOEXEC and EPOLL_NONBLOCK flags defined in 
it, so there would be many fewer cases of changes requiring all 
architectures to be updated, but that approach was rejected so instead we 
need architecture-specific copies of the whole header.

diff --git a/ChangeLog.mips b/ChangeLog.mips
index 9d79aea..2779bed 100644
--- a/ChangeLog.mips
+++ b/ChangeLog.mips
@@ -1,3 +1,9 @@
+2011-12-22  Joseph Myers  <>
+	[BZ #13538]
+	* sysdeps/unix/sysv/linux/mips/sys/epoll.h (EPOLLONESHOT)
+	(EPOLLET): Initialize with unsigned values.
 2011-12-19  Joseph Myers  <>
 	* sysdeps/unix/sysv/linux/mips/Makefile ($(objpfx)syscall-%.h
diff --git a/sysdeps/unix/sysv/linux/mips/sys/epoll.h b/sysdeps/unix/sysv/linux/mips/sys/epoll.h
index 6d2ec8e..51a657a 100644
--- a/sysdeps/unix/sysv/linux/mips/sys/epoll.h
+++ b/sysdeps/unix/sysv/linux/mips/sys/epoll.h
@@ -1,4 +1,4 @@
-/* Copyright (C) 2002-2006, 2007, 2008 Free Software Foundation, Inc.
+/* Copyright (C) 2002-2006, 2007, 2008, 2011 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    The GNU C Library is free software; you can redistribute it and/or
@@ -65,9 +65,9 @@ enum EPOLL_EVENTS
     EPOLLRDHUP = 0x2000,
-    EPOLLONESHOT = (1 << 30),
+    EPOLLONESHOT = 1u << 30,
-    EPOLLET = (1 << 31)
+    EPOLLET = 1u << 31

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]