This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] arm: fix PIC vs SHARED typos
On Mon, 19 Sep 2011, Mike Frysinger wrote:
> > But if they were
> > supported, the PIC code here looks better than the non-PIC - you can't
> > just put an absolute address in a constant pool in the text section in
> > position-independent code the way the non-PIC code does; the conditional
> > really does seem to be about "must the text be position-independent?".
>
> so it sounds there are two issues. there is PIC code behind "#ifdef PIC"
> which is good, but the code also decides which symbol name (which is a SHARED
> define) via PIC ? that's the part that i'm trying to fix.
> -mike
In that case you'll need to send a patch that handles PIC properly for
both SHARED and non-SHARED cases, with reference to the corresponding libc
conditionals as explanation of the basis for the differences between the
two.
--
Joseph S. Myers
joseph@codesourcery.com