This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [ARM,MIPS,M68K] Add new MADV_* values
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-ports at sourceware dot org, aurelien at aurel32 dot net
- Date: Wed, 18 Nov 2009 17:14:01 -0500
- Subject: Re: [ARM,MIPS,M68K] Add new MADV_* values
- References: <Pine.LNX.4.64.0911172047130.32327@digraph.polyomino.org.uk>
On Tue, Nov 17, 2009 at 3:53 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> This patch, corresponding to a recent libc change, adds new MADV_*
> definitions for ARM, MIPS and M68K. ?I've committed the ARM and MIPS
> changes; OK to commit the M68K ones?
I would personally prefer it if your ChangeLog called out exactly
those definitions that were added.
e.g. MADV_MERGEABLE and MADV_UNMERGABLE (and on mips MADV_HWPOISON).
> * I did not use Aurelien's patch from bug 10972, but instead followed the
> libc changes as closely as possible. ?Apart from the libc change also
> defining MADV_HWPOISON, it appears the ports patch in that bug is
> incorrect for hppa at least (that uses different values, but the patch
> adds the generic values there). ?So alpha and hppa will need updating
> separately (with patches adding the same set of macros as for the other
> architectures, with the right values for those architectures).
I have a patch in my tree for hppa.
Cheers,
Carlos.