This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [Patch][RFC] ARM NPTL lll_futex_wake_unlock() issue
From: "Carlos O'Donell" <carlos@systemhalted.org>
Subject: Re: [Patch][RFC] ARM NPTL lll_futex_wake_unlock() issue
Date: Wed, 10 Sep 2008 19:35:28 -0400
> On Thu, Sep 4, 2008 at 10:16 AM, <ryosei@sm.sony.co.jp> wrote:
> > Could you please give me some comments??
> >
> > Index: glibc-2.7/glibc-ports-2.7/sysdeps/unix/sysv/linux/arm/nptl/lowlevellock.h
> > ===================================================================
> > --- glibc-2.7.orig/glibc-ports-2.7/sysdeps/unix/sysv/linux/arm/nptl/lowlevellock.h
> > +++ glibc-2.7/glibc-ports-2.7/sysdeps/unix/sysv/linux/arm/nptl/lowlevellock.h
> > @@ -110,7 +110,7 @@
> > __ret = INTERNAL_SYSCALL (futex, __err, 6, (futexp), \
> > __lll_private_flag (FUTEX_CMP_REQUEUE, private),\
> > (nr_wake), (nr_move), (mutex), (val)); \
> > - __ret; \
> > + INTERNAL_SYSCALL_ERROR_P (__ret, __err); \
> > })
> >
> >
> > @@ -123,7 +123,7 @@
> > __lll_private_flag (FUTEX_WAKE_OP, private), \
> > (nr_wake), (nr_wake2), (futexp2), \
> > FUTEX_OP_CLEAR_WAKE_IF_GT_ONE); \
> > - __ret; \
> > + INTERNAL_SYSCALL_ERROR_P (__ret, __err); \
> > })
> >
>
> This looks correct to me. I will be applying this patch to hppa after
> it completes testing.
Thank you.
I have executed glibc testsuite on ARM.
No regression was found.
Best Regards,
Ryosei Takagi