This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] glibc-ports-2.7 ARM DOCARGS assembler error patch
- From: "Deepak Barua" <dbbarua at gmail dot com>
- To: "Mike Frysinger" <vapier at gentoo dot org>
- Cc: libc-ports at sourceware dot org
- Date: Fri, 22 Feb 2008 22:22:21 +0530
- Subject: Re: [PATCH] glibc-ports-2.7 ARM DOCARGS assembler error patch
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=UMZi6q8rBTdj+0356T/+z97XnJjtFhfL65EOO8O/FnU=; b=kJZyaolDk211AuJEl9Plmua3zeuuIdGZltPX9qIYhcU6BUG5MgiJELLHgJdJ6mo5bnSVrioTJAkqcQ/8ycG2yQ018Ha5gRysjlPPOxqh/17XA6F81Isw/o8E/H2VWi7UZDrrk0AQmgejf7Dma2sBRECgvPgD4t0M2XvAJK6VGug=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=aN4GXABmZg6TG8DN56CHBy+YaxPsUDdGGH4y48dSjckkWWHeRPlpb6RH8AqatACPVKjkV/JSYTD2gezz8JbdLuanxyP2lj9rUFt5XJdve79N6xgshs7OWxRAjAEJ5ImO1HLkSow1v+DVgDzut9TA2ASV+j30oIj7gH07WmrDCbc=
- References: <b5a19cd20802212253v2f3c3xbbdafdd62a21525@mail.gmail.com> <200802220222.40672.vapier@gentoo.org>
Hi Mike,
Okay i'll take it in due consideration and look into it
.... i was worried about potential side effects of the changes
...thank you for your critical input.
Regards
Deepak
On 2/22/08, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday 22 February 2008, Deepak Barua wrote:
> > This is my first patch in glibc-ports i get the
> > following error when i compile my linux-2.6.23 kernel for ARM
> > architecture
> >
> > ) | arm-linux-gcc -c -I../include
> > -I/usr/arm/packages/toolchain/glibc-build-1/misc
> > -I/usr/arm/packages/toolchain/glibc-build-1 -I../ports/sysdeps/arm/elf
> > -I../ports/sysdeps/unix/sysv/linux/arm/nptl
> > -I../ports/sysdeps/unix/sysv/linux/arm
> > -I../ports/sysdeps/unix/sysv/linux -I../nptl/sysdeps/unix/sysv/linux
> > -I../nptl/sysdeps/pthread -I../sysdeps/pthread
> > -I../sysdeps/unix/sysv/linux -I../sysdeps/gnu -I../sysdeps/unix/common
> > -I../sysdeps/unix/mman -I../sysdeps/unix/inet
> > -I../ports/sysdeps/unix/sysv -I../nptl/sysdeps/unix/sysv
> > -I../sysdeps/unix/sysv -I../ports/sysdeps/unix/arm
> > -I../ports/sysdeps/unix -I../nptl/sysdeps/unix -I../sysdeps/unix
> > -I../sysdeps/posix -I../ports/sysdeps/arm/nptl -I../ports/sysdeps/arm
> > -I../sysdeps/wordsize-32 -I../sysdeps/ieee754/flt-32
> > -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754
> > -I../sysdeps/generic/elf -I../sysdeps/generic -I../ports -I../nptl
> > -I.. -I../libio -I. -nostdinc -isystem
> > /usr/lib/gcc/arm-linux/4.2.2/include -isystem
> > /usr/arm-linux/usr/include -D_LIBC_REENTRANT -include
> > ../include/libc-symbols.h -DASSEMBLER -x assembler-with-cpp -o
> > /usr/arm/packages/toolchain/glibc-build-1/misc/splice.o -
> > <stdin>: Assembler messages:
> > <stdin>:2: Error: bad instruction `docargs_6'
> > <stdin>:2: Error: bad instruction `undocargs_6'
> > make[2]: *** [/usr/arm/packages/toolchain/glibc-build-1/misc/splice.o]
> > Error 1 make[2]: Leaving directory
> > `/usr/arm/packages/toolchain/glibc-2.7/misc' make[1]: *** [misc/subdir_lib]
> > Error 2
> > make[1]: Leaving directory `/usr/arm/packages/toolchain/glibc-2.7'
> > make: *** [all] Error 2
> >
> >
> > I removed the references to docargs in
> > /glibc-ports-2.7/sysdeps/unix/sysv/linux/arm/nptl/sysdep-cancel.h so
> > that solves the problem.
> >
> > How ever i have not tested for larger impact of this removal of this
> > instruction ...
>
> clearly ... your patch just broke the arm code completely
>
> > Logically since the ARM assembler does not recognize this instruction
> > i beleive there is no harm in removing any reference to this .
>
> the logic is "if there is no assembly code, there cant be anything for the
> assembler to error on"
>
> search the Gentoo or Debian glibc patchsets. both have the real fix (which
> has been posted but not merged).
> -mike
>
>
--
Hack Hack Hack