This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [patch] hppa build failure with tls and lowlevellock.h
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Jeff Bailey" <jbailey at raspberryginger dot com>
- Cc: libc-ports at sourceware dot org, parisc-linux <parisc-linux at lists dot parisc-linux dot org>, "Matthias Klose" <doko at ubuntu dot com>
- Date: Fri, 7 Dec 2007 11:45:05 -0500
- Subject: Re: [patch] hppa build failure with tls and lowlevellock.h
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=7WKT3iLwJUlgWCWXiuIL+VlrPnURndgy3cIHNFWYfSM=; b=wH5+ZQ6rDOXDNKDHV3qVvuMdnhV8EaxUW7WvmtFs4MGudP+QJMxGU8xXNt+uLRqVMscwa0l31s/98v7FsV+UBD4Mxofxn7ZMttY7PSAjtrOScNdhstdJl8nWMHp0frncN8s5Y5b6o6h4fTJKi9v/zRDax93cqeVP7WdY1wEdS3M=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=r31F1v1T38thHTHysqEo/JWkm77R4YhNoEZQcrNafgCccwz0THavyrnOTgpHffqEzcWjNejnDOjq2qCOTJ1UHdPEV88tZKFtMqiYfdieeEMchL3hMhPhm7QtjspMNDmI5LhxNfA4ittohddmTcYOOOGoVj3PGcSeSxczqgmx780=
- References: <5b2e36650712051623uae77baet50684d0578729a49@mail.gmail.com>
On Dec 5, 2007 7:23 PM, Jeff Bailey <jbailey@raspberryginger.com> wrote:
> It turns out the reason we fail and others don't is that we use an
> inline function (so it's parsed right away) and everyone else uses a
> #define. You're probably still right that the include is unnecessary,
> but in the meantime this aligns us with everyone else and allows the
> build to continue.
>
> Okay to commit?
>
> 2007-12-05 Jeff Bailey <jeffbailey@google.com>
>
> * sysdeps/unix/sysv/linux/hppa/nptl/lowlevellock.h
> (__lll_unlock): Use define instead of inline function.
> (__lll_robust_unlock): Likewise.
Great sleuthing. OK to commit.
Cheers,
Carlos.