This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [parisc-linux] Re: [PATCH] Fix the atomic compare and swap function

From: "Carlos O'Donell" <carlos at systemhalted dot org>
To: "Aurelien Jarno" <aurelien at aurel32 dot net>
Cc: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>, libc-ports at sourceware dot org, parisc-linux at lists dot parisc-linux dot org
Date: Mon, 21 May 2007 00:59:39 -0400
Subject: Re: [parisc-linux] Re: [PATCH] Fix the atomic compare and swap function
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=d8DHzOwAv/XMrIIkXUJJJ0CKAZ9OEWrR2bKsy5/4E4beJVdjRh4SwSnNyjxlAQwANJPacsR1g2xBhN3NYuUb0vmXUBXtn9NgSyTrU9pQ728jNM6GbdKJdzh3lzNjXG2MAeqLCmUavfUMSWk3UR6vWDsYbJ63tyouPjYeihHvjdE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=IrtR04FvBLI3RDEl1PBM90zEiGkV9oX56jMl6gI1v3y1l3nHYV7Zhpui2hsQBG158p63wKgUR/dScO7vV7k7ru+ZenPOdYck/6LoKT+LGqMAyxB3afGepiUidw0CGEzSiUH0lqqX3t6Y8XL7aW+ht1egGi+InriMskiV7q5ppck=
References: <119aab440705200822vcfe3dd2ud542783a4ac2c3c8@mail.gmail.com> <200705201534.l4KFYknM023731@hiauly1.hia.nrc.ca> <20070520211900.GA22493@i386.aurel32.net>

On 5/20/07, Aurelien Jarno <aurelien@aurel32.net> wrote:

Then, what about this patch?

--- ports/sysdeps/unix/sysv/linux/hppa/bits/atomic.h.orig       2007-05-20 23:15:37.000000000 +0200
+++ ports/sysdeps/unix/sysv/linux/hppa/bits/atomic.h    2007-05-20 23:15:59.000000000 +0200
@@ -71,10 +71,10 @@
        "copy   %5, %%r24                       \n\t"                   \
        "ble    " LWS "(%%sr2, %%r0)            \n\t"                   \
        "ldi    " LWS_CAS ", %%r20              \n\t"                   \
+        "sub   %%r0, %%r21, %%r21              \n\t"                   \
        "cmpib,=,n " ASM_EAGAIN ",%%r21,0b      \n\t"                   \
        "nop                                    \n\t"                   \
        "stw    %%r28, %0                       \n\t"                   \
-        "sub   %%r0, %%r21, %%r21              \n\t"                   \
        "stw    %%r21, %1                       \n\t"                   \
        : "=m" (lws_ret), "=m" (lws_errno), "=m" (*mem)                 \
         : "r" (mem), "r" (oldval), "r" (newval)                                \


Looks OK to me. Please send me a revised patch with ChangeLog when you
are done your testing.

Cheers,
Carlos.

References:
- Re: [PATCH] Fix the atomic compare and swap function on hppa
  - From: Carlos O'Donell
- Re: [parisc-linux] Re: [PATCH] Fix the atomic compare and swap function
  - From: John David Anglin
- Re: [parisc-linux] Re: [PATCH] Fix the atomic compare and swap function
  - From: Aurelien Jarno

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]