This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Ping Re: PowerPC E500 port
- From: Roland McGrath <roland at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-ports at sourceware dot org
- Date: Mon, 19 Mar 2007 16:38:14 -0700 (PDT)
- Subject: Re: Ping Re: PowerPC E500 port
Please don't use compressed attachments. Just put the patches in your
email with the least amount of encoding you can manage.
I don't think the main powerpc files should do conditional includes of
nonexistent files like that. Instead, have your port override with a file
that #include's the main file. If you need to modify the main files to
facilitate that, I think a pure macro #ifdef bit without an #include is better.
You can use a gas macro in your file to make defining the part with your
code prettier than a big #define.
For changes to powerpc files in the main tree, you should get an OK from
Steve Munroe <sjmunroe@us.ibm.com> and then post to libc-alpha. For the
ports additions, with an OK from Steven and general review from me or
Daniel, one of us can commit it.
Thanks,
Roland