This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] powerp-cpu add-on for --with-cpu
- From: Roland McGrath <roland at redhat dot com>
- To: Steven Munroe <munroesj at us dot ibm dot com>
- Cc: libc-ports at sources dot redhat dot com, Tom Gall <tgall at us dot ibm dot com>
- Date: Tue, 13 Dec 2005 01:45:45 -0800 (PST)
- Subject: Re: [PATCH] powerp-cpu add-on for --with-cpu
The dl-procinfo (hwcap) stuff is independent of this new code. You should
not throw them together. The hwcap changes need to be in glibc proper and
agreed to by all concerned, as they constitute a new standard part of the
glibc ABI as it affects packaging of libraries. Some obvious errors in
your files make me doubt you ever actually compiled them. The strings you
used to describe the hwcap bits seem poorly chosen and are inconsistent
with what the analogous strings look like on other platforms. These names
will become the standard identifiers corresponding to these hwcap bits, and
need to be agreed upon by those concerned (i.e. the consensus among those
who chose the hwcap bit assignments). I've committed powerpc hwcap support
that lacks gratuitously insane code, and uses names that are what that
consensus will probably be. The selection of these names should be
confirmed with those concerned and adjusted to the final choices ASAP.
Followup on this issue belongs on the core libc lists, not on libc-ports.
Thanks,
Roland