Re: New mailing list <libc-ports@sources.redhat.com>

[Kazuhiro Inaoka <inaoka dot kazuhiro at renesas dot com>]

Roland McGrath wrote:

> For the trunk patches, you should post each unrelated change separately.
> Remember, for each change that you also need to see on the 2.3 branch,
> a bugzilla report is required.
>
>  
>
> > 	* Makeconfig (libc.so-gnulib): Added -lgcc_s$(libgcc_s_suffix)
> > 	to avoid undefined _Unwind_Find_FDE.
> >    
>
> Can you explain why this is needed?  This should not differ from other
> platforms where it hasn't been required.
The glibc's definition of _Unwind_Find_FDE function in
sysdeps/generic/unwind-dw2-fde-glibc.c is guarded with

#if !defined _LIBC || SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_2_5)

So I thought that the architecture started after 2.2.5 should use
_Unwind_Find_FDE given in libgcc.  Is the above guard right?
M32R was ported from 2.3.

> > 	* elf/elf.h (R_M32R_REL32): Added a relocation number.
> >    
>
> This one could go in.  Fix up the whitespace in the comments and post it
> alone to libc-alpha.  If there are other missing R_M32R_* numbers, or ones
> whose comments should be improved, do that as well.
I posted a patch to libc-alpha.

> > 	* sysdeps/unix/sysv/linux/futimes.c (__futimes): Use __libc_fcntl
> > 	instead of INLINE_SYSCALL macro to avoid undefined __NR_fcntl.
> > 	(M32r doesn't provide __NR_fcntl.)
> >    
>
> Don't deoptimize other configurations to support yours.
> If this is really necessary, conditionalize it on __NR_fcntl.
I see.
It is really necessary,  because m32r does not use __NR_fcntl.
I readied another patch. (futimes.c.patch)

> > 	* sysdeps/unix/sysv/linux/i386/fcntl.c: Include "kernel-features.h"
> > 	instead of "../kernel-features.h".
> > 	(ports/sysdeps/unix/sysv/linux/m32r/fcntl.c include this file.)
> >    
>
> If you want it to be searched for the right thing is <>.  Using "" means it
> will get i386/kernel-features.h if that were to exist.
I will create a new fcntl.c instead of include i386/fcntl.c.

Thanks,

Kazuhiro Inaoka

Index: futimes.c
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/futimes.c,v
retrieving revision 1.6.4.1
diff -u -r1.6.4.1 futimes.c
--- futimes.c	16 Feb 2005 10:47:26 -0000	1.6.4.1
+++ futimes.c	7 Nov 2005 08:37:11 -0000
@@ -88,7 +88,11 @@
       case ENOENT:
 	/* Validate the file descriptor by letting fcntl set errno to
 	   EBADF if it's bogus.  Otherwise it's a /proc issue.  */
+#ifdef __NR_fcntl
 	if (INLINE_SYSCALL (fcntl, 3, fd, F_GETFD, 0) != -1)
+#eles
+	if (__libc_fcntl (fd, F_GETFD) != -1)
+#endif
 	  __set_errno (ENOSYS);
 	break;
       }