This is the mail archive of the
libc-locales@sourceware.org
mailing list for the GNU libc locales project.
Re: [PATCH][BZ 18934] hu_HU: Fix multiple sorting bugs.
On 03/15/2017 04:36 PM, Egmont Koblinger wrote:
> Hi guys,
>
> Any progress on this one?
>
> What is blocking or delaying this issue? Is there anything I can help
> to move forward quicker?
At a high level the patch looks perfect.
I have only minor details that we should fix before commit. Almost
there.
Please review the changes below.
In hu_HU.in:
(a) tests you created.
+alphabet a ; These tests were created by egmont@gmail.com.
Exactly which tests were created by you?
Normally we don't include attribution in source files like this, instead
I'll add an item to NEWS about the additional coverage for Hungarian
and credit you there with the various tests you created.
In summary:
- Remove this comment.
- Add a bigger NEWS entry to the patch and I'll help review that.
You'll also get attribution in the git commit author.
Is that sufficient for you?
(b) foreign accents.
+foreign-o1 ó ; The rules are not explicit whether foreign accents on top of o or u
+foreign-o1 ò ; should be sorted among o-ó and u-ú, or among ö-ő and ü-ű,
+foreign-o1 òp ; but the example with Møsstrand makes it clear that it's the former.
I assume the Møsstrand example refers to:
+AkH-15 cérna ; #15: Foreign accents are ignored, unless they're the only difference,
+AkH-15 Černý ; in which case they are sorted after the Hungarian ones (in unspecified order).
...
+AkH-15 Goethe
+AkH-15 moshat
+AkH-15 mosna
+AkH-15 Mošna
+AkH-15 mosópor
+AkH-15 Møsstrand
^^^^^^^^^
+AkH-15 mostan
+AkH-15 munka
+AkH-15 Muñoz
...
If so then please clarify in the comment that you are referring
to test AkH-15.
Did you also design the foreign accent tests?
+foreign-a1 á ; More thorough tests for foreign accents (#15).
+foreign-a1 à
+foreign-a1 àp
+foreign-a1 áq
+foreign-a2 á
...
If you did create them then you should mention the new tests in the NEWS entry also.
In summary:
- Remove attribution at the file level.
- Add clarification to Møsstrand comment for future readers.
- Add a NEWS entry with verbose description of the update and new tests created by you.
Please post v2 and I'll commit that right away.
--
Cheers,
Carlos.