This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: [PATCH][RFC] Make malloc routines use mmap if heap is corrupt
On Tue, Sep 27, 2011 at 04:19:08PM +0200, Marek Polacek wrote:
> On 09/27/2011 04:09 PM, Siddhesh Poyarekar wrote:
> > Should I add the missing ChangeLog (and follow the rest of the
> > checklist too) and post here or directly on libc-alpha?
>
> Well I think you should post directly on libc-alpha, since those who can
> really review your patch probably don't read libc-help list at all.
>
> > +/* Set if a memory corruption is detected and if we're about to abort().
> > + That way, the heap is no longer touched by the alloc routines and we
> > + also avoid any deadlocks that may result from the loader or other
> > + threads trying to allocate memory in the same heap. This is only set if
> > + we're trying to print a backtrace and a memory map information before
> > + we abort. */
>
> Two spaces after every sentence.
>
I will post on libc-alpha after modifications. Thank you for the rest
of your suggestions!
--
Siddhesh