This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: [PATCH] build_wcs_upper_buffer definition
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: chris dot steel dot lnx at googlemail dot com
- Cc: libc-help at sourceware dot org
- Date: Wed, 26 Nov 2008 14:47:24 -0500
- Subject: Re: [PATCH] build_wcs_upper_buffer definition
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=pBrgEOsNlSLOOxkFmPXvnJJAbrsFQB4iU5PFLFEjZu4=; b=aHuTLpgLqc135pz/TqLbZnEsrvJ//AmXj2x5OgMtF8rbEL22p/OSnX6xswVRPg3hw6 uY1Iuic2FblhPeCEp78CBWooDRAemHpQsISiSFE/J3SFJAp07v/3I4lOP7OhadV6hr5A YaY73px2UacjFaBdx4lH9nfvGzQcQOxgGTwGQ=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=IZtg2YayTi7YUtf4WwJfSXhw/Tb9+p8MvsduJh56PNju9u3coKUOa9XWqkk4AVda4T 1l2fsDKNl1yrwDkgdtsZiiSKmCeb4wqoRzZfr03EwJG/j33AxtWaFv/2609A5/ucfzEi wMmgNtWLcxgGe+Xd2p/0hpz07wzsep/BdHJ2s=
- References: <cb31d0c70811261123rbe81555s8f5ec86739941745@mail.gmail.com>
On Wed, Nov 26, 2008 at 2:23 PM, Chris Steel
<chris.steel.lnx@googlemail.com> wrote:
> build_wcs_upper_buffer is defined in posix/regex_internal.h to have a
> return type of int, but it's used in posix/regex_internal.c and
> posix/regexec.c with a return type of reg_errcode_t. This patch fixes
> the problem:
You will need to write a proper GNU ChangeLog for your patch, and it
would be good to show that the testsuite shows no regressions e.g. run
the testsuite before your patch, and after, with no difference.
With those changes I think your patch should be good to go on libc-alpha.
Cheers,
Carlos.