This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
[PATCH] build_wcs_upper_buffer definition
- From: "Chris Steel" <chris dot steel dot lnx at googlemail dot com>
- To: libc-help at sourceware dot org
- Date: Wed, 26 Nov 2008 19:23:28 +0000
- Subject: [PATCH] build_wcs_upper_buffer definition
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :to:subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=SG9RGPG1mTac5Y6klFgD1e9Y9QlJI+npXf9CsF5riU0=; b=Dsq7yY32VYgVgWLiH+b7HjIDomFSJ55XAMI3tL3H+1keXzvt54/voTc/3hyISu6/if d7f9wdWsmk4yuheDx5Y/AJe/T+ik0bPIcHHuqCuwA/Y+aEEF4wndSznf4wOB6ZJeKNlm t509w5KEBbbjsBbk3fp44DlhDK21cNOTXbU/U=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=i4D/KuotXkz2CPzLi6RZLQ4h0Y75U8b46plrDjFNSiP0cIA3I4MqinlETn+/sQMeSu Xgr1/yNjh5G0KZ+CvgIbDwppfwdcR9edGlcGGEH8NLVJo2E0OR/hYcTRVpUTim+5ymGo zW1ZEuFzd3esz8bg5XazizxjFlA3XvyD5e19Q=
- Reply-to: chris dot steel dot lnx at googlemail dot com
Hi,
I think I've found a small coding error in glibc which breaks my build.
build_wcs_upper_buffer is defined in posix/regex_internal.h to have a
return type of int, but it's used in posix/regex_internal.c and
posix/regexec.c with a return type of reg_errcode_t. This patch fixes
the problem:
diff -urN glibc-2.9-20081124-clean/posix/regex_internal.h
glibc-2.9-20081124/posix/regex_internal.h
--- glibc-2.9-20081124-clean/posix/regex_internal.h 2007-08-26
02:35:05.000000000 +0100
+++ glibc-2.9-20081124/posix/regex_internal.h 2008-11-25
11:43:12.482102615 +0000
@@ -391,7 +391,7 @@
internal_function;
# ifdef RE_ENABLE_I18N
static void build_wcs_buffer (re_string_t *pstr) internal_function;
-static int build_wcs_upper_buffer (re_string_t *pstr) internal_function;
+static reg_errcode_t build_wcs_upper_buffer (re_string_t *pstr)
internal_function;
# endif /* RE_ENABLE_I18N */
static void build_upper_buffer (re_string_t *pstr) internal_function;
static void re_string_translate_buffer (re_string_t *pstr) internal_function;
Regards
Chris