This is the mail archive of the libc-help@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC]setlocale() race condition


On Tue, Jun 24, 2008 at 12:47 AM, Sharyathi Nagesh <sharyath@in.ibm.com> wrote:
> Carlos
> Excuse me for the late response
>        Here is the mail with update as you suggested

Excellent work! You've come a long way from your original posting.

> ========================================================================
> GNU Changelog
>
> 2008-06-12      Sharyathi Nagesh        <sharyathi@in.ibm.com>
>        * locale/setlocale.c (setlocale): Fix Race condition while
>            calling strcmp().

The format of the ChangeLog is not correct.

Please see the GNU Coding Standards (http://www.gnu.org/prep/standards/).

The canonical format is:
[yy-mm-dd][2 spaces][name][2 spaces]<[email]>
[blank line]
[tab]*[1 space][filename][1 space]([function]:[1 space][description]

The description is not correct either. The text should succinctly
describe what you did e.g. "Call FOO before accessing BAR."

Cheers,
Carlos O'Donell


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]