This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fix version map sorting


The math/Versions file has an inline comment which is mishandled by the
version map scripts:

    exp2; exp2f; # exp2l; -- bug omitted this until GLIBC_2.4 (below)

Such inline comments are not stripped, and the dot in it becomes
significant when sorting the temporary versions file.  On targets where
GLIBC_2.2 is the earliest version for libm this causes the file to be
out of order: this line is sorted as if belonging to GLIBC_2.2.4.  Fixed
by putting the comment on a line by itself.

Andreas.

2009-01-22  Andreas Schwab  <schwab@suse.de>

	* math/Versions: Avoid inline comment.

--- math/Versions	29 Mär 2005 11:41:38 +0200	1.9
+++ math/Versions	22 Jan 2009 00:42:47 +0100	
@@ -94,7 +94,8 @@ libm {
   }
   GLIBC_2.1 {
     # mathematical functions
-    exp2; exp2f; # exp2l; -- bug omitted this until GLIBC_2.4 (below)
+    exp2; exp2f;
+    # exp2l; -- bug omitted this until GLIBC_2.4 (below)
     exp10; exp10f; exp10l;
     fdim; fdimf; fdiml;
     fma; fmaf; fmal;

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]