This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

About stdlib/strto* change

Hi,

There is a build failure for SH during compiling stdlib/strtold_l.c:

strtold_l.c:61: error: 'strtold_l' aliased to undefined symbol '__strtold_l'

In Aug 6 Roland's change, libc_hidden_proto (__strtold_l) is added
to include/stdlib.h and weak_alias (__STRTOLD, STRTOLD) is added to
stdlib/strtold_l.c.  It seems that libc_hedden_def is needed also
for __strtold_l just before the above weak_alias statement.  Is it
right?  x86 uses sysdeps/ieee754/ldbl-96/strtold_l.c which includes
stdlib/strtod_l.c instead of stdlib/strtold_l.c and the corresponding
libc_hedden_def was added to stdlib/strtod_l.c at that time.
The attached patch works for me, though I suspect that I've missed
something.

Regards,
	kaz
--
	* stdlib/strtold.c: Add libc_hidden_def.

--- ORIG/libc/stdlib/strtold_l.c	2005-12-14 20:14:13.000000000 +0900
+++ LOCAL/libc/stdlib/strtold_l.c	2007-08-13 20:43:24.000000000 +0900
@@ -1,4 +1,4 @@
-/* Copyright (C) 1999, 2002, 2004 Free Software Foundation, Inc.
+/* Copyright (C) 1999, 2002, 2004, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -55,4 +55,7 @@ __STRTOLD (const STRING_TYPE *nptr, STRI
 {
   return INTERNAL (__STRTOD) (nptr, endptr, 0, loc);
 }
+#if defined _LIBC && !defined USE_WIDE_CHAR
+libc_hidden_def (__STRTOLD)
+#endif
 weak_alias (__STRTOLD, STRTOLD)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]