This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Misc small warning fixes


Hi!

When __NR_utimensat is not defined, gcc warns about miss_utimensat being
defined, but never used.
And without the second hunk __getpagesize is implicitly prototyped in PPCs
pthread_attr_setstacksize.

2007-05-28  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/futimes.c (miss_utimensat): Don't define
	if __NR_utimensat is not defined.

	* sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c: Include
	unistd.h.

--- libc/sysdeps/unix/sysv/linux/futimes.c.jj	2007-05-28 15:07:37.000000000 +0200
+++ libc/sysdeps/unix/sysv/linux/futimes.c	2007-05-28 15:07:37.000000000 +0200
@@ -1,5 +1,5 @@
 /* futimes -- change access and modification times of open file.  Linux version.
-   Copyright (C) 2002,2003,2005,2006 Free Software Foundation, Inc.
+   Copyright (C) 2002,2003,2005,2006,2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -29,7 +29,7 @@
 #include <kernel-features.h>
 
 
-#ifndef __ASSUME_UTIMENSAT
+#if defined __NR_utimensat && !defined __ASSUME_UTIMENSAT
 static int miss_utimensat;
 #endif
 
--- libc/nptl/sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c.jj	2006-10-07 21:51:33.000000000 +0200
+++ libc/nptl/sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c	2007-05-28 15:16:12.000000000 +0200
@@ -1,3 +1,4 @@
+#include <unistd.h>	/* For __getpagesize.  */
 #define NEW_VERNUM GLIBC_2_6
 #define STACKSIZE_ADJUST \
   do {									      \

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]