This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PPC fenv fixes 4th update

Ulrich Drepper wrote:
> Steven Munroe wrote:
>   
>> +/* This is presently a stub, until it's decided how the kernels should
>> +   support this.  */
>> +
>> +const fenv_t *
>> +__fe_mask_env(void)
>> +{
>> +  __set_errno (ENOSYS);
>> +  return FE_DFL_ENV;
>> +}
>>     
>
> Why are you sending a patch if it's incomplete?  Fix the kernel and then
> send a patch.  Who knows, maybe a completely different solution is needed.
>
>   
The only problem is the comment which should say:

/* This is a generic stub. An OS specific override is required to clear
   the FE0/FE1 bits in the MSR.  MSR update is privileged, so this will
   normally involve a syscall.  */

The real implementations for linux are in
sysdeps/unix/sysv/linux/powerpc/powerpc[32|64]/fe_mask.c

hhhmm should not this be?:
sysdeps/unix/sysv/linux/powerpc/powerpc[32|64]/fpu/fe_mask.c

History bites. Dr. Bergner just copied the existing fe_nomask.c stubs
and overrides. I'll fix it and resubmit.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]