This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix uninitialized var in gai_suspend

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Wed, 6 Sep 2006 18:37:03 +0200
Subject: [PATCH] Fix uninitialized var in gai_suspend
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

GAI_MISC_WAIT macro only sets result on error, so without this patch
we return an uninitialized value.

2006-09-06  Jakub Jelinek  <jakub@redhat.com>

	* resolv/gai_suspend.c (gai_suspend): Make sure result is initialized.

--- libc/resolv/gai_suspend.c.jj	2006-08-03 10:03:46.000000000 +0200
+++ libc/resolv/gai_suspend.c	2006-09-06 17:30:22.000000000 +0200
@@ -83,6 +83,7 @@ gai_suspend (const struct gaicb *const l
       pthread_setcancelstate (PTHREAD_CANCEL_DISABLE, &oldstate);
 
 #ifdef DONT_NEED_GAI_MISC_COND
+      result = 0;
       GAI_MISC_WAIT (result, cntr, timeout, 1);
 #else
       if (timeout == NULL)

	Jakub

Follow-Ups:
- Re: [PATCH] Fix uninitialized var in gai_suspend
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]