This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: sysdeps/generic changes


Roland McGrath wrote:

I tried to do a somewhat exhaustive change of #include "" to <> in cases
where it might have been wrong.  I left many "" cases that were clearly
right or clearly didn't matter, though I also changed some that didn't
really matter.  Hopefully I changed all the ones that matter and didn't
change any that shouldn't have been changed.

After this it's probably possible to move header files from sysdeps/generic
into respective subdirs for headers that are only referenced within their
own subdir (the top-level subdir whose Makefile lists that header).
Similarly, nptl/sysdeps/{pthread,generic} files that are only used in the
libpthread build can move to nptl/.



The latest changes are causing a build breaks. The first problem is with the tricky include recussion in nptl/sysdeps/pthread/sigaction.c. With the new directory structure it is getting the ENOSYS stub instead of the __libc_sigaction from sysdeps/unix/sysv/linux. This seems to be problem for any arch that does not have a arch specific sigaction down the sysdeps/unix/sysv/linux path (powerpc being an example).

Placing a include stub in sysdeps/unix/sysv/linux/powerpc/sigaction.c is an effective work around.

There also seems to be a problem with the declaration of __libc_cleanup_routine in libc-lock.h (at least with gcc-3.4) still looking at this one ...

2005-12-12  Steven Munroe  <sjmunroe@us.ibm.com>

	* sysdeps/unix/sysv/linux/powerpc/sigaction.c: New file.

diff -urN libc24-cvstip-20051222/sysdeps/unix/sysv/linux/powerpc/sigaction.c libc24/sysdeps/unix/sysv/linux/powerpc/sigaction.c
--- libc24-cvstip-20051222/sysdeps/unix/sysv/linux/powerpc/sigaction.c	Wed Dec 31 18:00:00 1969
+++ libc24/sysdeps/unix/sysv/linux/powerpc/sigaction.c	Thu Dec 22 17:26:37 2005
@@ -0,0 +1,1 @@
+#include <sysdeps/unix/sysv/linux/sigaction.c>

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]