This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix 2 issues found by valgrind


Hi!

1) in internal_fnmatch we have is_seqval is uninitialized
   after we goto to normal_bracket, as we jump into the
   middle of is_seqval's scope, don't set it to anything
   and later on use it
2) tst-mktime2.c did not initialize tm.tm_isdst, yet mktime
   uses this

Will keep looking at other problems.

2004-11-29  Jakub Jelinek  <jakub@redhat.com>

	* posix/fnmatch_loop.c (internal_fnmatch): Clear is_seqval after
	normal_bracket label.

	* time/tst-mktime2.c (bigtime_test): Initialize tm.tm_isdst to -1.

--- libc/posix/fnmatch_loop.c.jj	2004-09-04 09:16:57.000000000 +0200
+++ libc/posix/fnmatch_loop.c	2004-11-29 17:32:06.284085221 +0100
@@ -600,6 +600,9 @@ FCT (pattern, string, string_end, no_lea
 			if (!is_range && c == fn)
 			  goto matched;
 
+			/* This is needed if we goto normal_bracket; from
+			   outside of is_seqval's scope.  */
+			is_seqval = 0;
 			cold = c;
 			c = *p++;
 		      }
--- libc/time/tst-mktime2.c.jj	2004-11-01 01:21:23.000000000 +0100
+++ libc/time/tst-mktime2.c	2004-11-29 15:01:24.509816991 +0100
@@ -78,6 +78,7 @@ bigtime_test (int j)
   struct tm tm;
   time_t now;
   tm.tm_year = tm.tm_mon = tm.tm_mday = tm.tm_hour = tm.tm_min = tm.tm_sec = j;
+  tm.tm_isdst = -1;
   now = mktime (&tm);
   if (now != (time_t) -1)
     {

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]