This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add GETCONF_DIR to UNSECURE_ENVVARS, allowcross-installs

From: Andreas Schwab <schwab at suse dot de>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Ulrich Drepper <drepper at redhat dot com>,Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Fri, 26 Nov 2004 12:01:51 +0100
Subject: Re: [PATCH] Add GETCONF_DIR to UNSECURE_ENVVARS, allowcross-installs
References: <20041126093019.GF8259@sunsite.mff.cuni.cz>

Jakub Jelinek <jakub@redhat.com> writes:

> @@ -263,12 +264,16 @@ bug-glob2-ENV = MALLOC_TRACE=$(objpfx)bu
>  $(objpfx)bug-glob2-mem: $(objpfx)bug-glob2.out
>  	$(common-objpfx)malloc/mtrace $(objpfx)bug-glob2.mtrace > $@
>  
> -$(inst_libexecdir)/getconf: $(objpfx)getconf FORCE
> +$(inst_libexecdir)/getconf: $(objpfx)getconf $(objpfx)getconf.speclist FORCE
>  	$(addprefix $(..)./scripts/mkinstalldirs ,\
>  		    $(filter-out $(wildcard $@),$@))
> -	for spec in `LC_ALL=C GETCONF_DIR=/dev/null \
> -		     $(run-program-prefix) $< \
> -		     _POSIX_V6_WIDTH_RESTRICTED_ENVS`; do \
> -		$(INSTALL_PROGRAM) $< $@/$$spec.new; \
> -		mv -f $@/$$spec.new $@/$$spec; \
> +	for spec in `cat $(objpfx)getconf.speclist`; do \
> +	  $(INSTALL_PROGRAM) $< $@/$$spec.new; \
> +	  mv -f $@/$$spec.new $@/$$spec; \

The exit code of $(INSTALL_PROGRAM) should not be ignored.

>  	done
> +
> +$(objpfx)getconf.speclist: getconf.speclist.h
> +	$(CC) -E $(CFLAGS) $(CPPFLAGS) $< \
> +	  | sed -n -e '/START_OF_STRINGS/,$${/_POSIX_V6_/{s/^[^"]*"//;s/".*$$//;p}}' \
> +	  > $@.new
> +	mv -f $@.new $@

I think FORCE should be changed to $(+force), and maybe the second rule
should use a stamp file or even proper dependencies.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

References:
- [PATCH] Add GETCONF_DIR to UNSECURE_ENVVARS, allow cross-installs
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]