This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Avoid unconditional debugging printf in res_query.c

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>, Roland McGrath <roland at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Thu, 12 Aug 2004 14:28:52 +0200
Subject: [PATCH] Avoid unconditional debugging printf in res_query.c
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

We certainly shouldn't pollute stdout by default...

2004-08-12  Jakub Jelinek  <jakub@redhat.com>

	* resolv/res_query.c (__libc_res_nsearch): Protect the debugging
	printf with #ifdef DEBUG and RES_DEBUG check.

--- libc/resolv/res_query.c.jj	2004-08-12 16:38:52.000000000 +0200
+++ libc/resolv/res_query.c	2004-08-12 16:42:09.696933969 +0200
@@ -239,8 +239,11 @@ __libc_res_nsearch(res_state statp,
 		return (__libc_res_nquery(statp, cp, class, type, answer,
 					  anslen, answerp));
 
-	printf("dots=%d, statp->ndots=%d, trailing_dot=%d, name=%s\n",
-	       (int)dots,(int)statp->ndots,(int)trailing_dot,name);
+#ifdef DEBUG
+	if (statp->options & RES_DEBUG)
+		printf("dots=%d, statp->ndots=%d, trailing_dot=%d, name=%s\n",
+		       (int)dots,(int)statp->ndots,(int)trailing_dot,name);
+#endif
 
 	/*
 	 * If there are enough dots in the name, let's just give it a

	Jakub

Follow-Ups:
- Re: [PATCH] Avoid unconditional debugging printf in res_query.c
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]