This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix posix_fadvise on powerpc32

From: Andreas Jaeger <aj at suse dot de>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: GNU libc hackers <libc-hacker at sources dot redhat dot com>
Date: Mon, 25 Aug 2003 12:02:19 +0200
Subject: Re: Fix posix_fadvise on powerpc32
References: <hohe46p2pv.fsf@byrd.suse.de> <3F49CA32.8040003@redhat.com>

Ulrich Drepper <drepper@redhat.com> writes:

> Andreas Jaeger wrote:
>
>>    int ret = INTERNAL_SYSCALL (fadvise64, err, 5, fd,
>> -			      __LONG_LONG_PAIR (offset >> 31, offset), len,
>> +			      __LONG_LONG_PAIR ((long)offset >> 31, (long)offset), len,
>
> Why should this be necessary in posix_fadvise()?  offset is of type off_t.

Just for completeness...

Ok to commit only the 64-bit file?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

References:
- Fix posix_fadvise on powerpc32
  - From: Andreas Jaeger
- Re: Fix posix_fadvise on powerpc32
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]