This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] backtrace fix for s390-32.

From: Martin Schwidefsky <schwidefsky at de dot ibm dot com>
To: libc-hacker at sources dot redhat dot com
Date: Fri, 21 Mar 2003 10:45:11 +0100
Subject: [PATCH] backtrace fix for s390-32.
Organization: IBM Deutschland GmbH

Hi,
for s390-32 there is a problem with backtrace/backtrace_symbols.
backtrace returns addresses that can have the high order bit set (the
bas/basr instructions used for function calling do this). These bits
have to be removed in backtrace or backtrace_symbols won't
return the correct symbols information.

blue skies,
  Martin.

2003-03-21  Martin Schwidefsky  <schwidefskyde.ibm.com>

	* sysdeps/s390/s390-32/backtrace.c (__backtrace): Remove high order
	bit from backtrace addresses.

diff -urN libc/sysdeps/s390/s390-32/backtrace.c libc-s390/sysdeps/s390/s390-32/backtrace.c
--- libc/sysdeps/s390/s390-32/backtrace.c	Fri Jul  6 06:56:03 2001
+++ libc-s390/sysdeps/s390/s390-32/backtrace.c	Fri Mar 21 10:14:15 2003
@@ -71,7 +71,7 @@
 	   out of range.  */
 	break;
 
-      array[cnt++] = stack->save_grps[8];
+      array[cnt++] = stack->save_grps[8] & 0x7fffffff;
 
       stack = (struct layout *) stack->back_chain;
     }

Follow-Ups:
- Re: [PATCH] backtrace fix for s390-32.
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]