This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Use __NO_INLINE__ checks in glibc headers


Jakub Jelinek <jakub@redhat.com> writes:

> Hi!
> 
> Now that gcc defines __NO_INLINE__ unless -O1+ was used and no -fno-inline was
> specified, here is a patch to actually use it in glibc, so that -O2 -fno-inline 
> #include <string.h>
> work.
> Alternatively, the ctype/stdlib/wchar checks could be replaced by simple
> #ifdef __USE_EXTERN_INLINES, since the other conditions are guarded in
> features.h (and anyone who uses -D__USE_EXTERN_INLINES with -fno-inline or
> -O1 and up just deserves what he wanted). If you'd like me to prepare this
> variant of the patch, just let me know.

IMO that variant would be the cleaner solution,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]