This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Warnings removal (linuxthreads/*pt-machine.h)

>>>>> Ulrich Drepper writes:

 > Andreas Jaeger <aj@suse.de> writes:
>> What do you think of the appended patch?  

 > Seems OK.

>> Btw. should testandset return long int like alpha,ia64,mips or int
>> like arm,hppa,i386,m68k,s390,sh ?  Depending on the answer some
>> prototypes need be changed.  IMO it should be long int.

 > long int is probably better.

I've committed that patch now with long int for testandset and like to
commit the following also.  Ok?

Andreas

2000-12-17  Andreas Jaeger  <aj@suse.de>

	* sysdeps/s390/pt-machine.h (testandset): Use long int as return
	value.
	* sysdeps/arm/pt-machine.h (testandset): Likewise.
	* sysdeps/hppa/pt-machine.h (testandset): Likewise.
	* sysdeps/i386/i686/pt-machine.h (testandset): Likewise.
	* sysdeps/i386/pt-machine.h (testandset): Likewise.
	* sysdeps/m68k/pt-machine.h (testandset): Likewise.
	* sysdeps/sh/pt-machine.h (testandset): Likewise.
	* sysdeps/sparc/sparc32/pt-machine.h (testandset): Likewise.
	* sysdeps/sparc/sparc64/pt-machine.h (testandset): Likewise.

============================================================
Index: linuxthreads/sysdeps/arm/pt-machine.h
--- linuxthreads/sysdeps/arm/pt-machine.h	1998/10/09 11:22:07	1.2
+++ linuxthreads/sysdeps/arm/pt-machine.h	2000/12/17 17:19:06
@@ -1,6 +1,6 @@
 /* Machine-dependent pthreads configuration and inline functions.
    ARM version.
-   Copyright (C) 1997, 1998 Free Software Foundation, Inc.
+   Copyright (C) 1997, 1998, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Philip Blundell <philb@gnu.org>.
 
@@ -29,7 +29,7 @@
    time; let's hope nobody tries to use one.  */
 
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   register unsigned int ret;
============================================================
Index: linuxthreads/sysdeps/i386/pt-machine.h
--- linuxthreads/sysdeps/i386/pt-machine.h	1999/12/02 08:14:01	1.8
+++ linuxthreads/sysdeps/i386/pt-machine.h	2000/12/17 17:19:07
@@ -1,6 +1,6 @@
 /* Machine-dependent pthreads configuration and inline functions.
    i386 version.
-   Copyright (C) 1996, 1997, 1998, 1999 Free Software Foundation, Inc.
+   Copyright (C) 1996, 1997, 1998, 1999, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Richard Henderson <rth@tamu.edu>.
 
@@ -30,7 +30,7 @@
 
 
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   int ret;
============================================================
Index: linuxthreads/sysdeps/i386/i686/pt-machine.h
--- linuxthreads/sysdeps/i386/i686/pt-machine.h	2000/05/24 15:32:28	1.11
+++ linuxthreads/sysdeps/i386/i686/pt-machine.h	2000/12/17 17:19:07
@@ -31,7 +31,7 @@
 
 
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   int ret;
============================================================
Index: linuxthreads/sysdeps/m68k/pt-machine.h
--- linuxthreads/sysdeps/m68k/pt-machine.h	1998/10/09 11:22:16	1.2
+++ linuxthreads/sysdeps/m68k/pt-machine.h	2000/12/17 17:19:07
@@ -1,6 +1,6 @@
 /* Machine-dependent pthreads configuration and inline functions.
    m68k version.
-   Copyright (C) 1996, 1998 Free Software Foundation, Inc.
+   Copyright (C) 1996, 1998, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Richard Henderson <rth@tamu.edu>.
 
@@ -25,7 +25,7 @@
 
 
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   char ret;
============================================================
Index: linuxthreads/sysdeps/sparc/sparc32/pt-machine.h
--- linuxthreads/sysdeps/sparc/sparc32/pt-machine.h	2000/04/11 17:00:50	1.6
+++ linuxthreads/sysdeps/sparc/sparc32/pt-machine.h	2000/12/17 17:19:07
@@ -1,6 +1,6 @@
 /* Machine-dependent pthreads configuration and inline functions.
    sparc version.
-   Copyright (C) 1996, 1997, 1998 Free Software Foundation, Inc.
+   Copyright (C) 1996, 1997, 1998, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Richard Henderson <rth@tamu.edu>.
 
@@ -24,7 +24,7 @@
 #endif
 
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   int ret;
============================================================
Index: linuxthreads/sysdeps/sparc/sparc64/pt-machine.h
--- linuxthreads/sysdeps/sparc/sparc64/pt-machine.h	2000/04/18 07:34:38	1.10
+++ linuxthreads/sysdeps/sparc/sparc64/pt-machine.h	2000/12/17 17:19:07
@@ -25,7 +25,7 @@
 
 
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   int ret;
============================================================
Index: linuxthreads/sysdeps/sh/pt-machine.h
--- linuxthreads/sysdeps/sh/pt-machine.h	2000/10/26 02:27:37	1.2
+++ linuxthreads/sysdeps/sh/pt-machine.h	2000/12/17 17:19:07
@@ -24,7 +24,7 @@
 #endif
 
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   int ret;
============================================================
Index: linuxthreads/sysdeps/s390/pt-machine.h
--- linuxthreads/sysdeps/s390/pt-machine.h	2000/09/28 23:17:35	1.2
+++ linuxthreads/sysdeps/s390/pt-machine.h	2000/12/17 17:19:07
@@ -1,6 +1,6 @@
 /* Machine-dependent pthreads configuration and inline functions.
    S390 version.
-   Copyright (C) 1999 Free Software Foundation, Inc.
+   Copyright (C) 1999, 2000 Free Software Foundation, Inc.
    Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
    This file is part of the GNU C Library.
 
@@ -24,7 +24,7 @@
 #endif
 
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   int ret;
============================================================
Index: linuxthreads/sysdeps/hppa/pt-machine.h
--- linuxthreads/sysdeps/hppa/pt-machine.h	2000/10/15 03:42:58	1.1
+++ linuxthreads/sysdeps/hppa/pt-machine.h	2000/12/17 17:19:07
@@ -38,7 +38,7 @@
 #define xstr(s) str(s)
 #define str(s) #s
 /* Spinlock implementation; required.  */
-PT_EI int
+PT_EI long int
 testandset (int *spinlock)
 {
   int ret;

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]