Re: --with-oldest-abi should be --enable-oldest-abi

["H . J . Lu" <hjl at valinux dot com>]

On Mon, Dec 04, 2000 at 01:47:09PM -0500, Roland McGrath wrote:
> As the subject says.  --with has prescribed meaning in the coding standards
> and is not right for this.  It needs to be an --enable option instead.

Here is a patch. --enable-oldest-abi/--disable-oldest-abi are treated
the same, which use the default setting. You have to use
--enable-oldest-abi=ABI to choose an oldest ABI.

BTW, I am enclosing the ChangeLog entry as well as the miss ones.


-- 
H.J. Lu (hjl@valinux.com)
---
2000-12-04  H.J. Lu  <hjl@gnu.org>

	* configure.in: Change --with-oldest-abi=ABI to
	--enable-oldest-abi=ABI.
	* configure: Rebuild.

2000-12-01  H.J. Lu  <hjl@gnu.org>

	* nss/getXXbyYY_r.c: Fix verioned symbol handling.
	* nss/getXXent_r.c: Likewise.
	* sysdeps/unix/sysv/linux/i386/chown.c: Likewise.

2000-11-30  H.J. Lu  <hjl@gnu.org>

	* scripts/abi-versions.awk (oldest_abi): New variable.
	Handle the oldest ABI supported.

	* Makerules ($(common-objpfx)abi-versions.h): Set oldest_abi
	for scripts/abi-versions.awk.

	* configure.in: Add --with-oldest-abi=ABI.
	* configure: Rebuild.

	* config.make.in (oldest-abi): New.

	* config.h.in (GLIBC_OLDEST_ABI): New.

	* csu/version.c (banner): Support GLIBC_OLDEST_ABI.

Index: configure.in
===================================================================
RCS file: /work/cvs/gnu/glibc/configure.in,v
retrieving revision 1.1.1.18
diff -u -p -r1.1.1.18 configure.in
--- configure.in	2000/12/04 18:35:17	1.1.1.18
+++ configure.in	2000/12/04 19:08:29
@@ -82,17 +82,6 @@ AC_ARG_WITH(headers, dnl
                           [default=compiler default]],
 	    sysheaders=$withval, sysheaders='')
 
-AC_ARG_WITH(oldest-abi, dnl
-[  --with-oldest-abi=ABI   the oldest ABI supported [e.g. 2.2]
-                          [default=glibc default]],
-	    oldest_abi=$withval, oldest_abi='')
-if test ! -z "$oldest_abi"; then
-  AC_DEFINE_UNQUOTED(GLIBC_OLDEST_ABI, "$oldest_abi")
-else
-  oldest_abi=default
-fi
-AC_SUBST(oldest_abi)
-
 AC_ARG_ENABLE(libio, dnl
 [  --enable-libio          build in GNU libio instead of GNU stdio],
  	      [if test $enableval = yes; then
@@ -132,6 +121,17 @@ AC_ARG_ENABLE(versioning, dnl
                           library objects [default=yes if supported]],
              enable_versioning=$enableval, enable_versioning=yes)
 
+AC_ARG_ENABLE(oldest-abi, dnl
+[  --enable-oldest-abi=ABI configure the oldest ABI supported [e.g. 2.2]
+                          [default=glibc default]],
+	    oldest_abi=$enableval, oldest_abi=no)
+if test "$oldest_abi" = yes || test "$oldest_abi" = no; then
+  oldest_abi=default
+else
+  AC_DEFINE_UNQUOTED(GLIBC_OLDEST_ABI, "$oldest_abi")
+fi
+AC_SUBST(oldest_abi)
+
 dnl Generic infrastructure for drop-in additions to libc.
 AC_ARG_ENABLE(add-ons, dnl
 [  --enable-add-ons[=DIR1,DIR2]...