This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

warning fixes



I've commited the appended patches to silence these valid GCC
warnings:

regex.c:2728: warning: operation on `idx' may be undefined
../sysdeps/generic/dl-cache.c:187: warning: assignment from incompatible pointer type

Andreas

2000-10-18  Andreas Jaeger  <aj@suse.de>

	* posix/regex.c (regex_compile): Change to get defined behaviour.

	* sysdeps/generic/dl-cache.c (_dl_load_cache_lookup): Change to
	avoid warning.

============================================================
Index: posix/regex.c
--- posix/regex.c	2000/09/14 08:21:48	1.82
+++ posix/regex.c	2000/10/18 10:43:03
@@ -2725,7 +2725,10 @@
 			    if (c1 == 1)
 			      range_start = extra[idx];
 			    while (c1-- > 0)
-			      SET_LIST_BIT (extra[idx++]);
+			      {
+				SET_LIST_BIT (extra[idx]);
+				++idx;
+			      }
 			  }
 #endif
 			had_char_class = false;
============================================================
Index: sysdeps/generic/dl-cache.c
--- sysdeps/generic/dl-cache.c	2000/10/11 07:45:30	1.23
+++ sysdeps/generic/dl-cache.c	2000/10/18 10:43:03
@@ -184,7 +184,8 @@
 	}
       else if (file && cachesize > sizeof *cache_new)
 	{
-	  cache = cache_new = (struct cache_file_new *) file;
+	  cache_new = file;
+	  cache = file;
 	  if (memcmp (cache_new->magic, CACHEMAGIC_NEW,
 		      sizeof CACHEMAGIC_NEW - 1)
 	      || memcmp (cache_new->version, CACHE_VERSION,

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]