This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: makefile support for BP tests


Andreas Schwab <schwab@suse.de> writes:

> $(if ...) is a recent addition to GNU make (version 3.78), so you should
> either update the version checks or rewrite this so that it works with
> version 3.75 (the earliest we currently require).

Thanks for catching that.

Everyone can keep 3.75 for now...

@@ -486,7 +500,10 @@ run-program-prefix = $(elf-objpfx)$(rtld
 else
 run-program-prefix =
 endif
-built-program-cmd = $(run-program-prefix) $(built-program-file)
+# Never use $(run-program-prefix) for the statically-linked %-bp test programs
+built-program-cmd = $(patsubst %,$(run-program-prefix),\
+			$(filter-out %-bp,$(built-program-file))) \
+		    $(built-program-file)
 
 ifndef LD
 LD := ld -X

I assume you approve of the rest, so I'll commit it.

Greg

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]