This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: syscalls.list changes: List arguments


Andreas Jaeger <aj@suse.de> writes:

> Ok, I've changed the mips specific file and checked it in.  I've added
> it for your information.

> I noticed some wrong signatures during the process.

Which sigs were wrong?  These?

sysdeps/unix/syscalls.list:swapon		-	swapon		i:s	swapon
sysdeps/unix/syscalls.list:sys_mknod	xmknod	mknod		i:pii	__syscall_mknod
sysdeps/unix/inet/syscalls.list:accept		-	accept		i:ipi	__libc_accept	accept
sysdeps/unix/inet/syscalls.list:getpeername	-	getpeername	i:ipi	getpeername
sysdeps/unix/inet/syscalls.list:getsockname	-	getsockname	i:ipi	getsockname
sysdeps/unix/sysv/linux/syscalls.list:swapon		-	swapon		i:si	__swapon	swapon

I'll fix them.

> Could somebody else please double check my changes?

I checked enough to see that you didn't break arg counts.  I haven't yet
checked that all key letters are correct.

> -s_execve	execve	execve		3	__syscall_execve
> +s_execve	execve	execve		i:sss	__syscall_execve

args 2 & 3 are not strings, but rather vectors of strings.  For now,
make them "p".

> -s_setrlimit	setrlimit setrlimit	3	__syscall_setrlimit
> +s_setrlimit	setrlimit setrlimit	i:ip	__syscall_setrlimit

According to the man pages, `3' was wrong and you corrected it.

> -s_truncate64	truncate64 truncate64	3	__syscall_truncate64
> +s_truncate64	truncate64 truncate64	i:siii	__syscall_truncate64

> -s_ftruncate64	ftruncate64 ftruncate64	3	__syscall_ftruncate64
> +s_ftruncate64	ftruncate64 ftruncate64	i:iiii	__syscall_ftruncate64

Again, it looks like the `3' was wrong and you corrected it by passing
a pair of 32-bit regs to make the 64-bit arg.

Thanks!

Greg

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]