This is the mail archive of the mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] fopencookie binary compatibility

>>>>> Jakub Jelinek writes:

Jakub> On Thu, May 18, 2000 at 12:49:10PM +0200, Andreas Jaeger wrote:
>> >>>>> Jakub Jelinek writes:
>> > Hi!
>> > cookie_seek_function_t type changed between 2.0 and 2.2, which causes binary
>> > incompatibility between programs using fopencookie compiled with glibc up to
>> > 2.1.x and glibc 2.2.
>> > This patch should add fopencookie@@GLIBC_2.2 and fopencookie@GLIBC_2.0, so
>> > that old programs can continue to work.
>> > +#ifdef weak_alias
>> > +compat_symbol (libc, _IO_old_fopencookie, fopencookie, GLIBC_2_0);
>> > +#endif
>> Is the #ifdef really needed?  I don't think so.
>> I'll check the patch in without this if this is ok.  Uli, what do you
>> think?

Jakub> That was cut'n'paste from oldiof[gs]etpos*, so if it is not needed here, it
Jakub> is not needed there either (and I assume it is not needed because e.g.
Jakub> oldiofclose.c does not have it).

It should not be needed because of the definition of weak_alias in
include/libc-symbols.h.  It's either a weak alias or a strong_alias.
I think the #ifdef can also be removed from oldiof[gs]etpos*.

 Andreas Jaeger
  SuSE Labs

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]