This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: use of malloc

To: Thorsten Kukuk <kukuk at suse dot de>
Subject: Re: use of malloc
From: Ulrich Drepper <drepper at redhat dot com>
Date: 24 Apr 2000 23:22:10 -0700
Cc: GNU libc hacker <libc-hacker at sourceware dot cygnus dot com>
References: <m3em7zqrt3.fsf@localhost.localnet> <20000425081122.A17677@Wotan.suse.de>
Reply-To: drepper at cygnus dot com (Ulrich Drepper)

Thorsten Kukuk <kukuk@suse.de> writes:

> Uli, please look at the ChangeLog file. You have removed similar free's
> in other parts of the NIS code.

In some of them.  But not the once where we terminated a function in
the case we found an error != ENOMEM.  This happened in the function I
changed together with the missing frees in the __nis_destroy_callback.
This must have leaked quite a lot.

> And your new Code is wrong. You derefence NULL Pointer !!!!!

Where?

> Please remove it complete and don't change code, which you don't
> understand in such a way.

Well, I understand enough to see that the functions are leaking a lot
of memory during normal operation.

> What do you think is xdr_free () good for ?

Something which is allocated using calloc() can be freed using free.

-- 
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

Follow-Ups:
- Re: use of malloc
  - From: Thorsten Kukuk

References:
- use of malloc
  - From: Ulrich Drepper
- Re: use of malloc
  - From: Thorsten Kukuk

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]