This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Misc fixes


You have introduced a larger number of new errors.

> --- libc/locale/programs/ld-time.c.jj	Tue Dec 28 11:28:26 1999
> +++ libc/locale/programs/ld-time.c	Tue Dec 28 14:37:33 1999
> @@ -219,7 +219,7 @@ time_finish (struct localedef_t *locale,
>  	  if (*str != '+' && *str != '-')
>  	    {
>  	      if (!be_quiet)
> -		error (0, 0, _("%s: direction flag in string %d in `era' field"
> +		error (0, 0, _("%s: direction flag in string %z in `era' field"
>  			       " is not '+' nor '-'"),
>  		       "LC_TIME", idx + 1);
>  	      /* Default arbitrarily to '+'.  */

The z in %z is a modifier.  As it is there would be no output
generated for the number.  Could you fix all these cases in your
patch?  (I konw gcc should warn about this and I have a patch, which I
sent yesterday, but it is not yet approved...)

-- 
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Cygnus Solutions `--' drepper at cygnus.com   `------------------------

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]