This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

don't install <bits/libc-lock.h>



No installed header file #include's <bits/libc-lock.h>, so I don't think we
should install that file at all.  It was the originally intended use that
installed headers would use the libc-lock macros in their minimized name
space-clean mode (#ifndef _LIBC), but as well as the name space cleanliness
of that file not having been observed, it turns out that there is no need
for the locking macros to actually be used in any installed header files.
(The original plan envisioned using them in public macros like getc, but
that predated the pthreads spec with flockfile et al.)

So here is a makefile patch that ought to suffice to stop installing
<bits/libc-lock.h>.


Thanks,
Roland



1998-11-29  Roland McGrath  <roland@baalperazim.frob.com>

	* Makefile (headers): Remove bits/libc-lock.h.
	(distribute): Add it here instead.

Index: Makefile
===================================================================
RCS file: /glibc/cvsfiles/libc/Makefile,v
retrieving revision 1.182
diff -u -b -p -r1.182 Makefile
--- Makefile	1998/11/20 17:21:07	1.182
+++ Makefile	1998/11/29 19:50:35
@@ -60,7 +60,7 @@ configure: configure.in aclocal.m4; $(au
 		   $(addprefix install-, no-libc.a bin lib data headers others)
 
 headers := errno.h sys/errno.h bits/errno.h limits.h values.h	\
-	   features.h gnu-versions.h bits/libc-lock.h bits/xopen_lim.h	\
+	   features.h gnu-versions.h bits/xopen_lim.h	\
 	   gnu/libc-version.h
 
 echo-headers: subdir_echo-headers
@@ -247,6 +247,7 @@ distribute  :=	README README.libm INSTAL
 		extra-lib.mk o-iterator.mk configure configure.in	\
 		aclocal.m4 config.h.in config.make.in config-name.in	\
 		Makefile.in sysdep.h set-hooks.h libc-symbols.h		\
+		bits/libc-lock.h \
 		version.h shlib-versions rpm/Makefile rpm/template	\
 		rpm/rpmrc glibcbug.in abi-tags stub-tag.h		\
 		test-skeleton.c include/des.h Versions.def		\


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]