This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] powerpc: Move cache line size to rtld_global_ro
* Tulio Magno Quites Machado Filho:
> Siddhesh Poyarekar <siddhesh@gotplt.org> writes:
>
>> On 16/01/20 10:07 pm, Carlos O'Donell wrote:
>>> On 1/10/20 5:27 PM, Tulio Magno Quites Machado Filho wrote:
>>>> Changes since v1:
>>>> - Updated copyright dates
>>>> - Added tests
>>>> - Fixed coding style issues
>>>> - Added macros __GLRO_DEF and __GLRO in the 64-bit case.
>>>> - Removed sysdeps/unix/sysv/linux/powerpc/dl-support.c in favor of
>>>> sysdeps/generic/dl-auxv.h which is included by elf/dl-support.c and
>>>> elf/dl-sysdep.c
>>>> - Removed sysdeps/unix/sysv/linux/powerpc/dl-sysdep.c
>>>>
>>>
>>> OK for master. This is probably the smallest change you can make to fix
>>> all of this up.
>>>
>>> This needs approval again by Siddhesh.
>>>
>>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>>
>> This is fine.
>
> I've just pushed both patches to master.
This appears to have caused (on powerpc-linux-gnu):
../sysdeps/powerpc/powerpc32/memset.S: Assembler messages:
../sysdeps/powerpc/powerpc32/memset.S:248: Error: syntax error; found ` ', expected `,'
../sysdeps/powerpc/powerpc32/memset.S:248: Error: junk at end of line: `lwz 8,(_dl_cache_line_size+4)@l(8)'
Thanks,
Florian