This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC v6 06/23] sysdeps: Use long types with 64-bit time_t on 32-bit archs
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Alistair Francis <alistair23 at gmail dot com>
- Cc: Arnd Bergmann <arnd at arndb dot de>, Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Florian Weimer <fweimer at redhat dot com>, Palmer Dabbelt <palmerdabbelt at google dot com>, "Maciej W. Rozycki" <macro at wdc dot com>, Zong Li <zongbox at gmail dot com>
- Date: Thu, 16 Jan 2020 22:41:04 +0000
- Subject: Re: [RFC v6 06/23] sysdeps: Use long types with 64-bit time_t on 32-bit archs
- Ironport-sdr: htoEF1CB5+wXsCHbLE8G14q570eSkNT5tGKQ0c2w5tX9WUMpoNcYbJ5QRvweZIkExNaUGhWTIX gU5fe8g+x9jv4em1ULhWbcStvZtq3f0zTUAYHk7Gw4gQowq2aB1RklKbqWAJkORQ2eOlR78Jim dOhZC+STzftU2GvMfKmmbvvDD9rXhrnHaFZsn+gxutQ6g2WTYdZ2K1DYVwxvYPqEhFsy250M+6 Qfx3SVz5x6MdGSlNps971xMecHmrFHmTwbsHTdqwyPCs8V1O4tho4yJhymAcqfLjjEUJDo1UBW 4CI=
- Ironport-sdr: 5es4q5Fes1M+k/Gs5iJayl7sHHkGT6J3UdgHgjb1uiBlvoxrUAf8BVZi3qH/dpyvFnHZ6acewS hCJbg+mqTNJRpd2cpler9F6GNX/QLKSl7CnY6ZXi2jQBV6sgCeaj5b40WXoUDm4Ee/UCStprv4 6/OtKWOYaQoGI/yQ+Ih/+0RggIdIF+KTUoqEHP+eEZ2Y2WniKRxsdT4Ma3wYysTvdMUtkHbPJ2 J+CmclT9vcFAYWki2RMjxaZMGpLe6pGkdqSH0EyPVq9P7khc4YYU+F9XyBn9M4x9QYWmbPmVKP 9RM=
- References: <cover.1578824547.git.alistair.francis@wdc.com> <96c5552629ae8b306cff4b5cef44ba00634276d2.1578824547.git.alistair.francis@wdc.com> <CAK8P3a0d8SVdOn4GF+-EoKbCH46y_ZBviVLYAVosC9rxqCZ3fw@mail.gmail.com> <CAKmqyKNiwXKV5jvgame62BOSyB0_EWp1hMBmHSqb8XN4=FQ5cA@mail.gmail.com> <CAK8P3a2VZRje+ynG-L2mfxfxk9UdmcMA=xGNk9x4ps33VfSsXA@mail.gmail.com> <CAKmqyKMgBe8neeRcz3vecdn+-sgea3_o65H=HXvRnvW_rN90CA@mail.gmail.com>
On Fri, 17 Jan 2020, Alistair Francis wrote:
> 1. Define __semid_ds32 in sysdeps/unix/sysv/linux/bits/sem.h based on
> macros in sem-pad.h
The usual rule applies that internal structures generally do not belong in
installed headers.
sysdeps/unix/sysv/linux/bits/sem.h should define the *public* struct
semid_ds. That public definition may eventually vary based on some #if
conditions (__USE_TIME_BITS64 or whatever _TIME_BITS=64 causes to be
defined - not yet, only once we're actually ready to support _TIME_BITS=64
as a complete, consistent interface). But if the purpose of a definition
is to pass into the kernel, rather than as a public API (under a public
name) for user programs, it does not belong in an installed header -
unless it's e.g. referenced in some other public structure in some way.
--
Joseph S. Myers
joseph@codesourcery.com